junkaixue commented on code in PR #2869:
URL: https://github.com/apache/helix/pull/2869#discussion_r1702355579
##########
helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java:
##########
@@ -555,9 +564,10 @@ void publishStatusUpdateRecord(ZNRecord record, Message
message, Level level,
*/
void publishErrorRecord(ZNRecord record, String instanceName, String
updateSubPath,
Review Comment:
Instead of using this approach to define param, let's do this:
create a new function:
void publishErrorRecord(ZNRecord record, String instanceName, String
updateSubPath,String updateKey, String sessionId, HelixDataAccessor accessor,
boolean isController, boolean logToZK);
Put all existing logic in this one and leverage this boolean flag to check.
For the old API, you can call this by passing
ERROR_LOG_TO_ZK_ENABLED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
