junkaixue commented on code in PR #2877:
URL: https://github.com/apache/helix/pull/2877#discussion_r1712041176
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/AutoRebalanceStrategy.java:
##########
@@ -560,7 +560,7 @@ private Map<Replica, Node>
computeExistingPreferredPlacement(
Replica replica = new Replica(partition, replicaId);
if (_preferredAssignment.containsKey(replica)
&& !existingPreferredAssignment.containsKey(replica)
- && _preferredAssignment.get(replica).id == node.id) {
+ && _preferredAssignment.get(replica).id == node.id &&
node.isAlive) {
Review Comment:
discussed offline. Need refine behavior consistent with current delay auto
rebalanced. It means when an instance disabled, it should still show in
preference list but in map field it showed as INITIAL state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
