junkaixue commented on PR #2886: URL: https://github.com/apache/helix/pull/2886#issuecomment-2303029102
> > We should be consistent with behavior. What if user does not specific MZs? > > If there is no topology set up for the cluster, I believe batch stoppable will actually return an empty. My current assumption is that this is due to the single instance stoppable check calling `getZoneBasedInstances` which seems will return an empty list when no topology set. For the batch instances check, it will return empty because it relies on _orderOfZones not being empty. > > the per instance stoppable check should work normally in this case. If this PR just make the fix without adding the non-zone based support, let's create ticket and making a TODO item in the code to make sure that support will happen later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
