junkaixue commented on code in PR #2892:
URL: https://github.com/apache/helix/pull/2892#discussion_r1733481269
##########
helix-gateway/src/main/java/org/apache/helix/gateway/api/service/HelixGatewayServiceChannel.java:
##########
@@ -35,10 +35,9 @@ public interface HelixGatewayServiceChannel {
* Gateway service send a state transition message to a connected
participant.
*
* @param instanceName the name of the participant
- * @param currentState the current state of the shard
* @param message the message to send
*/
- void sendStateTransitionMessage(String instanceName, String currentState,
Message message);
+ void sendStateTransitionMessage(String instanceName,Message message);
Review Comment:
Here's the confusing part:
1. If you are talking about Helix state transition, why not still have state
transition message? We will have target state, right?
2. If it is the message from Gateway manager to channel, then let's not call
it message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
