zpinto commented on code in PR #2922:
URL: https://github.com/apache/helix/pull/2922#discussion_r1767415123


##########
helix-gateway/src/main/java/org/apache/helix/gateway/util/StateTransitionMessageTranslateUtil.java:
##########
@@ -130,7 +130,7 @@ public static GatewayServiceEvent 
translateShardStateMessageToEventAndUpdateCach
    * @param clusterName the cluster name
    * @return GatewayServiceEvent
    */
-  public static GatewayServiceEvent translateClientCloseToEvent(String 
instanceName, String clusterName) {
+  public static GatewayServiceEvent translateClientCloseToEvent( String 
clusterName, String instanceName) {

Review Comment:
   Space before String



##########
helix-gateway/src/main/java/org/apache/helix/gateway/util/StateTransitionMessageTranslateUtil.java:
##########
@@ -144,7 +144,7 @@ public static GatewayServiceEvent 
translateClientCloseToEvent(String instanceNam
    * @param shardStateMap
    * @return
    */
-  public static GatewayServiceEvent translateCurrentStateChangeToEvent(String 
instanceName, String clusterName,
+  public static GatewayServiceEvent translateCurrentStateChangeToEvent( String 
clusterName, String instanceName,

Review Comment:
   space before String



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to