himanshukandwal commented on code in PR #2958:
URL: https://github.com/apache/helix/pull/2958#discussion_r1833325007


##########
helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java:
##########
@@ -525,6 +525,8 @@ private void cleanupWorkflow(String workflow) {
         // clean all the contexts even if Configs and IdealStates are exists. 
Then all the workflows
         // and jobs will rescheduled again.
         removeContexts(workflow, jobs, _clusterDataCache.getTaskDataCache());
+        // Request for full-data refresh to re-fetch workflow resource configs.
+        _clusterDataCache.requireFullRefresh();

Review Comment:
   Thanks @junkaixue for the review. 
   So we need updated resourceConfig, so another thing we can do here is:
   `_clusterDataCache.notifyDataChange(ChangeType.RESOURCE_CONFIG)` 
   
   so that in the next pipeline run, whichever Cluster event type it is, the 
resourceConfig will always be read from the ZK. That way, we will only making 
full refresh of ResourceConfigs. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to