MarkGaox commented on code in PR #2972:
URL: https://github.com/apache/helix/pull/2972#discussion_r1866244410
##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -656,6 +656,17 @@ public InstanceOperation getInstanceOperation() {
.build();
}
+ // if instance operation id DISABLE, we override it to ENABLE if instance
is enabled
+ if
(activeInstanceOperation.getOperation().equals(InstanceConstants.InstanceOperation.DISABLE))
{
+ // it is not likely that instanceEnabled is unset, because when we set
operation to disable,
+ // we always set instanceEnabled to false
Review Comment:
Could you please clarify the comments? Does 'InstanceEnabled' refer to
'HELIX_ENABLED'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
