junkaixue opened a new pull request, #2976: URL: https://github.com/apache/helix/pull/2976
### Issues - [] My PR addresses the following Helix issues and references them in the PR description: ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: Once tag removed from instance for assignment purpose, current behavior is: 1) no new tagged tasks assigns to that instance. 2) drop the existing running tasks. Change behavior for this: 1) keep no new tagged tasks assigns to that instance. 2) let existing tasks running to complete Test added. ### Tests - [X] The following tests are written for this issue: AfterClass: TestJobTagRemoval called. Shut down zookeeper at port 2183 in thread main =============================================== Default Suite Total tests run: 1, Failures: 0, Skips: 0 =============================================== - The following is the result of the "mvn test" command on the appropriate module: ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org