jacob-netguardians opened a new pull request, #2978:
URL: https://github.com/apache/helix/pull/2978

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   Fixes #2965
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   If two nodes try to register at about the same time in the cluster, there 
may be a race condition while effectively adding the instances to the cluster 
description in zookeeper (the second one seeing an incomplete node hierarchy 
and later on refusing to accept tasks). Having an atomic creation of those 
nodes in zookeeper should prevent that.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   No additional tests.
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in 
their subject lines. In addition, my commits follow the guidelines from "[How 
to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to