jacob-netguardians commented on code in PR #2977:
URL: https://github.com/apache/helix/pull/2977#discussion_r1876098065


##########
helix-core/src/main/java/org/apache/helix/controller/pipeline/AbstractBaseStage.java:
##########
@@ -64,9 +65,9 @@ public String getStageName() {
     return className;
   }
 
-  public static <T> Future asyncExecute(ExecutorService service, Callable<T> 
task) {
+  public static <T> Future<T> asyncExecute(ExecutorService service, 
Callable<T> task) {

Review Comment:
   Following the boy-scout rule, every time I see something which could be 
easily improved, I try to do so.
   
   Here for type-safety, it is useful for the caller of this method to 
know/remember that the "get" method on the future they just got would supply an 
object of type T instead of an object of any forgotten type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to