junkaixue commented on code in PR #2977: URL: https://github.com/apache/helix/pull/2977#discussion_r1878686916
########## helix-core/src/main/java/org/apache/helix/controller/pipeline/AbstractBaseStage.java: ########## @@ -64,9 +65,9 @@ public String getStageName() { return className; } - public static <T> Future asyncExecute(ExecutorService service, Callable<T> task) { + public static <T> Future<T> asyncExecute(ExecutorService service, Callable<T> task) { Review Comment: Let's minimize the this kind of change. The reason is that Helix release not only support java 11 but backward compatible with 8. Any this kind of "improvement" for working code may break backward build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org