jacob-netguardians commented on code in PR #2978:
URL: https://github.com/apache/helix/pull/2978#discussion_r1879421231
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java:
##########
@@ -503,8 +514,8 @@ private boolean canCompleteSwap(String clusterName, String
swapOutInstanceName,
if (swapInLiveInstance == null) {
logger.warn(
"SwapOutInstance {} is {} + {} and SwapInInstance {} is OFFLINE + {}
for cluster {}. Swap will"
- + " not complete unless SwapInInstance instance is ONLINE.",
- swapOutInstanceName, swapOutLiveInstance != null ? "ONLINE" :
"OFFLINE",
+ + " not complete unless SwapInInstance instance is ONLINE.",
swapOutInstanceName,
Review Comment:
Should be better now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
