junkaixue commented on code in PR #2993:
URL: https://github.com/apache/helix/pull/2993#discussion_r1917322187
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -158,7 +159,9 @@ public Response instancesOperations(@PathParam("clusterId")
String clusterId,
@QueryParam("continueOnFailures") boolean continueOnFailures,
@QueryParam("skipZKRead") boolean skipZKRead,
@QueryParam("skipHealthCheckCategories") String
skipHealthCheckCategories,
- @DefaultValue("false") @QueryParam("random") boolean random, String
content) {
+ @DefaultValue("false") @QueryParam("random") boolean random,
+ @DefaultValue("false") @QueryParam("skipCustomChecksIfNoLiveness")
boolean skipCustomChecksIfNoLiveness,
Review Comment:
I prefer not to have them as query param. The URL will be very very long and
not easy to propose.
Let's try to make them part of payloads. Payloads are more flexible and not
have backward compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
