xyuanlu commented on code in PR #2987: URL: https://github.com/apache/helix/pull/2987#discussion_r1920840142
########## helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java: ########## @@ -111,13 +121,29 @@ public Builder setReason(String reason) { /** * Set the source for this instance operation. - * @param source InstanceOperationSource - * that caused this instance operation to be triggered. + * + * @param source InstanceOperationSource that caused this instance operation to be triggered. + * @return Builder */ public Builder setSource(InstanceConstants.InstanceOperationSource source) { _properties.put(InstanceOperationProperties.SOURCE.name(), - source == null ? InstanceConstants.InstanceOperationSource.USER.name() - : source.name()); + source == null ? InstanceConstants.InstanceOperationSource.USER.name() : source.name()); Review Comment: nit: should we have a field for default source? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org