zpinto commented on PR #2998: URL: https://github.com/apache/helix/pull/2998#issuecomment-2599360495
This PR is ready to be merged. Commit message: - Fixing the flaky topology migration check which should isolate shuffling to a single instance tag. After investigation, a fix was needed for ContraintBasedAlgorithm to compute the replica hash using only the assignable instances for a given instance tag. This is to ensure that cluster topology changes to instances with specific tags only affects resources with those tags. - Fix incorrect condition to decide whether to add swap in instance state to the stateMap in BestPossibleStateCalcStage, so no null values can be set for state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org