GrantPSpencer opened a new pull request, #3003: URL: https://github.com/apache/helix/pull/3003
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: fixes #2937 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Issue #2937 is likely due to slow ZK performance. The GC occurs on an async thread, so it is possible that GC is occurring but deletion of Znodes has not yet completed so read is served before deletion is written to ZK server. This PR introduces 3 changes to TestZkBucketDataAcessor.testGCScheduler 1. Rename testGCScheduler --> testGCCompletesUnderHighFrequency 2. Assertion logic has changed. No longer has strict check that can be flaky due to slow ZK connection. Now leverages verifier that will continuously write to ZK shorter than GC timeout and will only exist once GC has occurred. This maintains test logic that GC will occur under high frequency writes. 3. Isolates paths between test methods ### Tests - [ ] The following tests are written for this issue: testGCCompletesUnderHighFrequency - The following is the result of the "mvn test" command on the appropriate module: ``` [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.helix.manager.zk.TestZkBucketDataAccessor [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.113 s - in org.apache.helix.manager.zk.TestZkBucketDataAccessor [INFO] [INFO] Results: [INFO] [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 ``` ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: N/A ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
