junkaixue commented on code in PR #3006:
URL: https://github.com/apache/helix/pull/3006#discussion_r1960184690
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java:
##########
@@ -1223,7 +1225,13 @@ boolean isFlapping() {
public void handleStateChanged(KeeperState state) {
switch (state) {
case SyncConnected:
+ // If manager is disconnected and is the leader controller, then reset
and init leaderElectionHandler. This
+ // will force the controller to refresh and pick up any events that were
missed during disconnect.
+ if (_managerDisconnectedPastTimeout && _controller != null &&
isLeader()) {
+ _controller.scheduleOnDemandRebalance(0, true);
+ }
Review Comment:
This is not a proper handling. If you need the full refresh, you can clean
up the cache and let pipeline to read data. This will trigger another full
refresh after pipeline running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
