GrantPSpencer opened a new pull request, #3015:
URL: https://github.com/apache/helix/pull/3015
### Issues
When waged rebalance fails due to an exception that matches failure types to
propagate, the controller errors out of the pipeline run and does not finish
calculating a best possible state for that resource. This leads to an empty
best possible state, when then leads to the partitions for that resource being
dropped from nodes then immediately being reassigned once calculation proceeds.
This is because the following code in MessageGenerationPhase drops the
partitions:
```
// Look through the current state map and add DROPPED message if the
instance is not in the
// resourceStateMap. This instance may not have had been dropped by the
rebalance strategy.
// This check is required to ensure that the instances removed from the
ideal state stateMap
// are properly dropped.
for (String instance : currentStateMap.keySet()) {
if (!instanceStateMap.containsKey(instance)) {
instanceStateMap.put(instance, HelixDefinedState.DROPPED.name());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
