xyuanlu commented on PR #3017: URL: https://github.com/apache/helix/pull/3017#issuecomment-2797805900
Had an offline discussion about wether we want to use multistream with configAccessor or using dataAccessor. if we use multistream with configAccessor, we need to follow the pattern for all current usage of configAccessor - call `ZKUtil.isInstanceSetup` check before calling configAccessor. It is not efficient as inside configAccessor, it is `ZKUtil.isInstanceSetup` called again, resulting in many duplicate ZK read. If we change to using dataAccessor, we need to deprecate the prev API and create a new one. Considering we need to get all instances config in the cluster, I think we could favor performance to code style. And also do code clean in follow up changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
