GrantPSpencer opened a new pull request, #3034: URL: https://github.com/apache/helix/pull/3034
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: fixes #3018 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Change behavior in message generation when state exists in current state map but not in the best possible state only when the best possible state map actually contains a mapping for the partition. This is to prevent the case where the best possible state map does not contain a mapping for a resource because calculation failed (failureResources in BestPossibleStateCalcStage). More information can be seen in the issue #3018 ### Tests - [ ] The following tests are written for this issue: TestPreserveAssignmentsOnRebalanceFailure TestRebalancePipeline.testNoMessagesSentOnNoResourceMapping - The following is the result of the "mvn test" command on the appropriate module: ``` $ mvn test -o -Dtest=TestPreserveAssignmentsOnRebalanceFailure,TestRebalancePipeline -pl=helix-core [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:17 min [INFO] Finished at: 2025-05-05T17:27:50+05:30 [INFO] ------------------------------------------------------------------------ ``` ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: N/A ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
