MarkGaox commented on code in PR #3031:
URL: https://github.com/apache/helix/pull/3031#discussion_r2076145390
##########
helix-core/src/main/java/org/apache/helix/model/ClusterTopologyConfig.java:
##########
@@ -83,6 +82,26 @@ public static ClusterTopologyConfig
createFromClusterConfig(ClusterConfig cluste
return new ClusterTopologyConfig(true, endNodeType, faultZoneType,
topologyKeyDefaultValue);
}
+ /**
+ * Replace the fault zone in the given topology string with the new fault
zone.
+ *
+ * @param topologyString the topology string to be modified
+ * @param newFaultZone the new fault zone to be set
+ * @return the modified topology string
+ */
+ public String replaceFaultZoneInTopologyString(String topologyString, String
newFaultZone) {
Review Comment:
Thanks for the review. Moved this logic from `ClusterTopologyConfig` to
`VirtualTopologyGroupService` which is now only used in helix-rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
