GrantPSpencer opened a new pull request, #3040: URL: https://github.com/apache/helix/pull/3040
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Performance improvement ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Currently, PropertyKey path is built on every call to PropertyKey.getPath() and performs regex match. This can be expensive and redundant as when we add a listener, we loop through the existing handlers and call propertyKey.getPath() for every handler that exists. The performance hit will be most noticeable in clusters with a large instance count. Technically, this will make it so that PropertyKey.getPath() will no longer update after instantiation if the underlying PropertyPathBuilder's templateMap is updated. However, I did not find this being done anywhere in the code so in effect there should be no change ### Tests - [ ] The following tests are written for this issue: None - The following is the result of the "mvn test" command on the appropriate module: N/A ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
