csudharsanan commented on code in PR #3043:
URL: https://github.com/apache/helix/pull/3043#discussion_r2110418681
##########
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java:
##########
@@ -163,6 +163,16 @@ private void generateMessage(final Resource resource,
final BaseControllerDataPr
// desired-state->list of generated-messages
Map<String, List<Message>> messageMap = new HashMap<>();
+ // Calculate metadata for message prioritization
+ int totalInstanceCount = instanceStateMap.keySet().size();
+
+ // Get pending upward state transition messages to second top or top
state
+ List<Message> pendingUpwardStateTransitionMessages =
getPendingUpwardStateTransitionMessages(
+ resourceName, partition, currentStateOutput, stateModelDef);
+
+ // Initialize replica counter for prioritization
+ int initialReplicaNumber = totalInstanceCount -
pendingUpwardStateTransitionMessages.size();
Review Comment:
yes it does, haven't excluded it as its still a part of the transition
process. Do you have any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
