LZD-PratyushBhatt commented on PR #3044: URL: https://github.com/apache/helix/pull/3044#issuecomment-3066703706
> Highly recommend the new contributor starting with stablizing the tests instead of touch the very core part. It is very very dangerous. There was one line log change can blast the entire server before. > > If you still believe your change is solid, we can help review. At the same time, please never lower the bar. Hey @junkaixue, Yes I believe the current version of the change is solid and is in good shape. I have tested the change thoroughly with multiple test cases. Please take a look at this once you get time! Thanks a lot for your time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
