Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm ...................................................................... Patch Set 5: (1 comment) I appreciate your reviews. http://gerrit.cloudera.org:8080/#/c/8489/5/be/src/exprs/scalar-expr.cc File be/src/exprs/scalar-expr.cc: http://gerrit.cloudera.org:8080/#/c/8489/5/be/src/exprs/scalar-expr.cc@260 PS5, Line 260: // Compute the alignment of this value. Values should be self-aligned for > This formatting is weird - the old formatting was better. Thanks for the fix. The weird formatting comes from my vi setting. Anyway, I should have reviewed the difference after pushing... -- To view, visit http://gerrit.cloudera.org:8080/8489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a Gerrit-Change-Number: 8489 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 16 Nov 2017 00:15:41 +0000 Gerrit-HasComments: Yes
