Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8572 )
Change subject: IMPALA-6184: Clean up aftr ScalarExprEvaluator::Clone() fails ...................................................................... Patch Set 1: (2 comments) Just a couple of questions. http://gerrit.cloudera.org:8080/#/c/8572/1/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/8572/1/be/src/exprs/scalar-expr-evaluator.cc@193 PS1, Line 193: Status status = Kinda subtle, can you add a comment like the one above? // Always add the evaluator to the vector so it can be cleaned up. http://gerrit.cloudera.org:8080/#/c/8572/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test File testdata/workloads/functional-query/queries/QueryTest/udf-errors.test: http://gerrit.cloudera.org:8080/#/c/8572/1/testdata/workloads/functional-query/queries/QueryTest/udf-errors.test@85 PS1, Line 85: on (bad_expr2(rand()) = (t2.bool_col && t1.bool_col)); Is this one guaranteed to fail? It seems like if we're unlucky, rand() could not return one of the values that BadExpr fails on. -- To view, visit http://gerrit.cloudera.org:8080/8572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ffd722d0a69ad05ae3c748cf504c7f1a959a1d Gerrit-Change-Number: 8572 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 16 Nov 2017 15:50:19 +0000 Gerrit-HasComments: Yes
