Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )
Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q61.test File testdata/workloads/tpcds/queries/tpcds-q61.test: http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q61.test@4 PS8, Line 4: -- FIXED. CAST RESULT QUOTIENT TO DECIMAL(15, 4), USE ACTUAL RESULT AS EXPECTED RESULT Similar to others can you please add expected Vs actual? http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q77a.test File testdata/workloads/tpcds/queries/tpcds-q77a.test: http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q77a.test@4 PS8, Line 4: -- FIXED, MADE UNIFORM 1/100 PRECISION. USE ACTUAL RESULT AS EXPECTED RESULT Similar to others can you please add expected Vs actual? http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q78.test File testdata/workloads/tpcds/queries/tpcds-q78.test: http://gerrit.cloudera.org:8080/#/c/8372/8/testdata/workloads/tpcds/queries/tpcds-q78.test@4 PS8, Line 4: -- FIXED. USE ACTUAL RESULT AS EXPECTED RESULT Similar to others can you please add expected Vs actual? -- To view, visit http://gerrit.cloudera.org:8080/8372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a Gerrit-Change-Number: 8372 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2017 02:27:12 +0000 Gerrit-HasComments: Yes
