Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 )
Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C ...................................................................... Patch Set 5: > The only way to guarantee that there is no race condition around > is_query_cancelled flag is to Introduce locking around that variable. It certainly does make sense to swallow cancellation errors, especially if they're "query doesn't exist." I'll note that if we're having trouble with the "reset", we need not: a query can only go from running to cancelled. It can't go from cancelled back to running. There's still a race, of course, if the query finishes and we try to cancel it, which is what I think you're saying. > Re: flaky tests If it's stable ~100 times, I think it's fine to push it in. If it turns out to be a bad idea, we'll change the test. -- To view, visit http://gerrit.cloudera.org:8080/8549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cefaf1dae78baae238289816a7cb9d210fb38e2 Gerrit-Change-Number: 8549 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 18 Nov 2017 00:52:16 +0000 Gerrit-HasComments: No
