Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 )
Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...................................................................... Patch Set 6: (1 comment) Thank Sailesh for review. fixed now. I will use clang-format-diff.py for formatting next time. > Uploaded patch set 6. http://gerrit.cloudera.org:8080/#/c/8510/2/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/8510/2/be/src/util/openssl-util.cc@107 PS2, Line 107: const EVP_CIPHER* evpCipher = IsCtrSupported() ? EVP_aes_256_ctr() : EVP_aes_256_cfb(); > long line thank you for review. these two issues are fixed now -- To view, visit http://gerrit.cloudera.org:8080/8510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib97939f2334838263364b53ef3413871638bf53e Gerrit-Change-Number: 8510 Gerrit-PatchSet: 6 Gerrit-Owner: Xianda Ke <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mike Yoder <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Xianda Ke <[email protected]> Gerrit-Comment-Date: Sun, 19 Nov 2017 05:03:04 +0000 Gerrit-HasComments: Yes
