Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8622 )
Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert ...................................................................... KUDU-2220: GetEndOfChainX509 does not return end-user cert KUDU-2091 introduced a function GetEndOfChainX509() which was supposed to return the "end-user" certificate. However, the end-user certificate is not at the end of the chain, but rather at the beginning of the chain as specificed by the RFC: https://tools.ietf.org/html/rfc5246#section-7.4.2 | This is a sequence (chain) of certificates. The sender's certificate MUST | come first in the list. Each following certificate MUST directly certify | the one preceding it. This patch fixes this by changing the GetEndOfChainX509() to GetTopOfChainX509(). An existing test is modified to test this patch. It does not pass without this change. Change-Id: I0e3f913259ec4c855ff211726fa6ecea94d328e7 Reviewed-on: http://gerrit.cloudera.org:8080/8595 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> Reviewed-on: http://gerrit.cloudera.org:8080/8622 Reviewed-by: Michael Brown <mi...@cloudera.com> Reviewed-by: Michael Ho <k...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/kudu/rpc/rpc-test.cc M be/src/kudu/security/ca/cert_management.cc M be/src/kudu/security/cert.cc M be/src/kudu/security/cert.h M be/src/kudu/security/test/test_certs.cc M be/src/kudu/security/tls_context.cc M be/src/kudu/security/tls_handshake.cc 7 files changed, 65 insertions(+), 22 deletions(-) Approvals: Michael Brown: Looks good to me, but someone else must approve Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0e3f913259ec4c855ff211726fa6ecea94d328e7 Gerrit-Change-Number: 8622 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
