Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8631 )
Change subject: IMPALA-6227: deflake admission stress tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8631/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8631/1//COMMIT_MSG@11 PS1, Line 11: All of the accounting in the test implicitly relies on queries not being : dequeued until queries are later explicitly ended, so if this happened, : the test broke in multiple subtle ways. > and this assumption is no longer true because of the final change for IMPAL I don't think it was ever true for the mem_limit tests. Even before IMPALA-1575 it depended implicitly on the memory staying reserved on all backends. >From what I can tell, the bug was always there, it was a tweak to the >statestore frequency that threw it out of balance. http://gerrit.cloudera.org:8080/#/c/8631/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/8631/1/tests/custom_cluster/test_admission_controller.py@705 PS1, Line 705: b4 > where is that used? Leftover debugging code that I missed removing. http://gerrit.cloudera.org:8080/#/c/8631/1/tests/custom_cluster/test_admission_controller.py@792 PS1, Line 792: amount of time > is this actually timing sensitive, or is it that as long as we don't fetch It shouldn't be timing sensitive. Updated the comment. -- To view, visit http://gerrit.cloudera.org:8080/8631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb3af0ce68f96e5d713dbb3b37dd0b50ea66bb4 Gerrit-Change-Number: 8631 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 22:45:50 +0000 Gerrit-HasComments: Yes
