Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 )
Change subject: IMPALA-2181: Add query option levels for display ...................................................................... Patch Set 20: (2 comments) (Also didn't look too much at the python shell code.) http://gerrit.cloudera.org:8080/#/c/8447/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8447/20//COMMIT_MSG@14 PS20, Line 14: HS2 interface I think that should say "the SET SQL statement" or similar, since SET can be executed via HS2 or beeswax. It's just that the shell doesn't use it today. http://gerrit.cloudera.org:8080/#/c/8447/20/common/thrift/beeswax.thrift File common/thrift/beeswax.thrift: http://gerrit.cloudera.org:8080/#/c/8447/20/common/thrift/beeswax.thrift@98 PS20, Line 98: maybe we should be super explicit here and say: // Impala extension: ... to point out that this isn't part of the "standard" beeswax interface. I don't think anything else in this file was customized for Impala besides this. (The customization usually happens in ImpalaService.thrift. We could even add this functionality there instead, but I don't feel strongly given that this seems like a backwards compatible modification and beeswax will go away. -- To view, visit http://gerrit.cloudera.org:8080/8447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1 Gerrit-Change-Number: 8447 Gerrit-PatchSet: 20 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 23 Nov 2017 01:03:55 +0000 Gerrit-HasComments: Yes
