Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8588 )
Change subject: IMPALA-4927: Impala should handle invalid input from Sentry ...................................................................... IMPALA-4927: Impala should handle invalid input from Sentry Impala requests a list of roles from Sentry and then asks for privileges for each role. If Sentry returns a non existent role in the first step, then there will be a Java exception in Impala in the second step and the communication with Sentry is aborted. The issue is fixed by handling the exception if an invalid role is found and continue with getting permissions for the rest of the roles. Testing: ------- Since invalid role could not be created through impala-shell/Hue interface the code was instrumented to have an invalid Role " ", and SHOW ROLES statement was executed from impala shell to see how the condition is handled. Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Reviewed-on: http://gerrit.cloudera.org:8080/8588 Reviewed-by: Alex Behm <[email protected]> Reviewed-by: Zach Amsden <[email protected]> Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/util/SentryProxy.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Alex Behm: Looks good to me, but someone else must approve Zach Amsden: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I781411018d580854d80a9cad81a1ded7ca16af8b Gerrit-Change-Number: 8588 Gerrit-PatchSet: 11 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Zach Amsden <[email protected]>
