Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 )
Change subject: IMPALA-6067: Enable S3 access via IAM roles for EC2 VMs ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8294/3/bin/check-s3-access.sh File bin/check-s3-access.sh: http://gerrit.cloudera.org:8080/#/c/8294/3/bin/check-s3-access.sh@56 PS3, Line 56: > you don't need the semicolon Done http://gerrit.cloudera.org:8080/#/c/8294/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/8294/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@3001 PS3, Line 3001: ype This test is removed as the s3n: URL could not be changed to s3a:, that would have defeated the goal of the test. Coverage for invalid, but still parseable URLs is still provided by the remaining test step checking 'file:///' URLs. http://gerrit.cloudera.org:8080/#/c/8294/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl: http://gerrit.cloudera.org:8080/#/c/8294/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.tmpl@59 PS3, Line 59: <property> > Is there any reason not to s/s3a/s3n/ in the tests so that we can get rid o Done. The credentials section is now completely removed (it can still be added manually if someone really needs it); dummy credentials required by the FE tests are supplied via environment variables. s3a: can take this form; s3n:, which can only understand the entries in core-site.xml has been removed from the codebase. I had to remove a single test from AnalyzeStmtsTest.java so that s3n: could be completely removed; I left some notes there. -- To view, visit http://gerrit.cloudera.org:8080/8294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14cd9d4453a91baad3c379aa7e4944993fca95ae Gerrit-Change-Number: 8294 Gerrit-PatchSet: 4 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Nov 2017 14:01:35 +0000 Gerrit-HasComments: Yes
