Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8668 )
Change subject: IMPALA-6053: Fix exception when storadeIds don't match hosts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8668/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/8668/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@353 PS1, Line 353: LOG.error(String.format("Number of storage IDs and number of hosts for block " + : "%s mismatch (storageIDs:hosts) %d:%d. Skipping disk ID loading for this " + : "block.", location.toString(), storageIds.length, hosts.length)); wouldn't this spam the logs if we do it for every block? Maybe we should group the errors and log it less often. Also, FWIW, I think with this patch, these bocks locs are also reported in unknown disk IDs, so we might as well remove this error log. so your call. -- To view, visit http://gerrit.cloudera.org:8080/8668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d685208dce7a1cbe94a33b8ac9aeb7c8a3f391 Gerrit-Change-Number: 8668 Gerrit-PatchSet: 1 Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2017 19:39:48 +0000 Gerrit-HasComments: Yes
