Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8623 )
Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection ...................................................................... IMPALA-6187: Fix missing conjuncts evaluation with empty projection Previously, scanners will assume that there are no conjuncts associated with a scan node for queries with no materialized slots (e.g. count(*)). This is not necessarily the case as one can write queries such as select count(*) from tpch.lineitem where rand() * 10 < 0; or select count(*) from tpch.lineitem where rand() > <a partition column>. In which case, the conjuncts should still be evaluated once per row. This change fixes the problem in the short-circuit handling logic for count(*) to evaluate the conjuncts once per row and only commits a row to the output row batch if the conjuncts evaluate to true. Testing done: Added the example above to the scanner test Change-Id: Ib530f1fdcd2c6de699977db163b3f6eb38481517 Reviewed-on: http://gerrit.cloudera.org:8080/8623 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Reviewed-by: Alex Behm <alex.b...@cloudera.com> Reviewed-by: Dan Hecht <dhe...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/hdfs-sequence-scanner.cc M be/src/exec/kudu-scanner.cc M be/src/exec/kudu-scanner.h M testdata/workloads/functional-query/queries/QueryTest/kudu-scan-node.test M testdata/workloads/functional-query/queries/QueryTest/scanners.test 8 files changed, 74 insertions(+), 11 deletions(-) Approvals: Tim Armstrong: Looks good to me, but someone else must approve Alex Behm: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8623 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib530f1fdcd2c6de699977db163b3f6eb38481517 Gerrit-Change-Number: 8623 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
