Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8656 )
Change subject: IMPALA-6244: Fix test failures with Hadoop 3.0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test File testdata/workloads/functional-query/queries/QueryTest/show-stats.test: http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@85 PS2, Line 85: ---- RESULTS: VERIFY_IS_EQUAL > VERIFY_IS_EQUAL should not be needed False, if using row_regex. Somewhat true if using column regex and this is a late enough column to be distinct. The problem is that rows will be sorted by default if VERIFY_IS_EQUAL is not provided, and the sort does not take any accounting for the presence of regular expressions in either rows or columns. https://github.com/cloudera/Impala/blob/cdh5-trunk/tests/common/test_result_verifier.py#L385 http://gerrit.cloudera.org:8080/#/c/8656/2/testdata/workloads/functional-query/queries/QueryTest/show-stats.test@86 PS2, Line 86: '2009','1',-1,1,'19.59KB','NOT CACHED','NOT CACHED','TEXT','false','$NAMENODE/test-warehouse/alltypesmixedformat/year=2009/month=1' > just change them all Done -- To view, visit http://gerrit.cloudera.org:8080/8656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ccffdb0f712da1feb55f839e8d87a30f15e4fb6 Gerrit-Change-Number: 8656 Gerrit-PatchSet: 2 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2017 03:45:16 +0000 Gerrit-HasComments: Yes
