Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 )
Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names ...................................................................... Patch Set 3: > Patch Set 2: > > For future reference here's a good place for such tests: > webserver/test_web_pages.py > > No need to hold up the patch, change seems easy enough. Thanks for the hint. The DiskIoMgr unittest failed because it uses more disks than are present in the system. I made the code more resilient to this. While I was at it, I also added a test. Tim, Alex, does one of you have time for a second look? -- To view, visit http://gerrit.cloudera.org:8080/8669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b Gerrit-Change-Number: 8669 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Nov 2017 20:35:18 +0000 Gerrit-HasComments: No
