Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 )
Change subject: IMPALA-6068: Scale back fixing functional-types ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8690/4/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/8690/4/testdata/datasets/functional/functional_schema_template.sql@a2115 PS4, Line 2115: What the heck is this actually doing? If I am reading this correctly, it is loading the data twice, both times with OVERWRITE, so the net effect is simply more time spent doing the data load, with no validation that the results are the same. -- To view, visit http://gerrit.cloudera.org:8080/8690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c242cca209a7138b10ad517076707709b5cd204 Gerrit-Change-Number: 8690 Gerrit-PatchSet: 4 Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-Comment-Date: Fri, 01 Dec 2017 17:48:44 +0000 Gerrit-HasComments: Yes
