Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8748 )
Change subject: IMPALA-5987: LZ4 Codec silently produces bogus compressed data for large inputs ...................................................................... Patch Set 1: Code-Review+2 (2 comments) LGTM aside from a couple of comments about comments http://gerrit.cloudera.org:8080/#/c/8748/1/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: http://gerrit.cloudera.org:8080/#/c/8748/1/be/src/util/decompress-test.cc@445 PS1, Line 445: TEST_F(DecompressorTest, LZ4Huge) { Can you add a comment referencing the JIRA number? Might be helpful to understand the motivation for the test. http://gerrit.cloudera.org:8080/#/c/8748/1/be/src/util/decompress-test.cc@459 PS1, Line 459: // Compression succeeds! Maybe mention what the expected behaviour is? This almost sounds like it *should* succeed. -- To view, visit http://gerrit.cloudera.org:8080/8748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb0bc4ed98c5d7b628b791aa90ead36347b9fbb8 Gerrit-Change-Number: 8748 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2017 17:32:53 +0000 Gerrit-HasComments: Yes
