Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8751 )
Change subject: IMPALA-6238: Enhance TErrorCode::DATASTREAM_SENDER_TIMEOUT message ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8751/1/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8751/1/be/src/runtime/krpc-data-stream-mgr.cc@338 PS1, Line 338: ss << "(" << ctx->rpc_context->remote_address().host() << ")"; how about Substitute()? Does this need a blank space at the beginning, given how the error message string is formatted? -- To view, visit http://gerrit.cloudera.org:8080/8751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e83773fe6feda057296e7d5544690aa9271fa0 Gerrit-Change-Number: 8751 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Comment-Date: Mon, 04 Dec 2017 20:22:10 +0000 Gerrit-HasComments: Yes
