Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8761 )
Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set ...................................................................... IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set In Impala, we have FLAGS_principal and FLAGS_be_principal flags. If only FLAGS_principal is set, we use it as both the internal and external principals. If both FLAGS_principal and FLAGS_be_principal are set, we use FLAGS_be_principal as the internal principal and FLAGS_principal as the external principal. However, in Kudu, they only source the internal principal from FLAGS_principal and aren't aware of a flag called FLAGS_be_principal. So as of the time IMPALA-5129 went in, if FLAGS_be_principal is explicitly set to something different from FLAGS_principal, we would be using the external principal as the internal principal, which is incorrect. This is fixed on the Kudu side by the following commit: https://github.com/apache/kudu/commit/d42c2916467b83347f064ddea59f7a65202f7247 This is now cherry-picked to Impala and we now use the new API to fix this problem. Testing: Made the MiniKdc explicitly set FLAGS_principal and FLAGS_be_principal. Confirmed that the tests fail without this patch and with FLAGS_be_principal set. Change-Id: If5af4398467857da09878075439b6612a04d7a01 Reviewed-on: http://gerrit.cloudera.org:8080/8761 Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/rpc/authentication.cc M be/src/testutil/mini-kdc-wrapper.cc 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Dan Hecht: Looks good to me, but someone else must approve Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If5af4398467857da09878075439b6612a04d7a01 Gerrit-Change-Number: 8761 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
