Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 )
Change subject: IMPALA-6262: Always initialize runtime profile for DataSink ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8770/2/be/src/exec/data-sink.cc File be/src/exec/data-sink.cc: http://gerrit.cloudera.org:8080/#/c/8770/2/be/src/exec/data-sink.cc@49 PS2, Line 49: state-> I guess you may assume state cannot be nullptr. If so, why don't you pass state using reference type instead of pointer? I could see several argument passing in this change. Reference type is more intuitive to guarantee the variable points an object. -- To view, visit http://gerrit.cloudera.org:8080/8770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a683000ef180027b929dbebe78bc2a530a4767e Gerrit-Change-Number: 8770 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2017 14:30:28 +0000 Gerrit-HasComments: Yes
