Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 )
Change subject: IMPALA-6270: create Impala parent pom ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8753/1/impala-parent/CMakeLists.txt File impala-parent/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8753/1/impala-parent/CMakeLists.txt@19 PS1, Line 19: COMMAND $ENV{IMPALA_HOME}/bin/mvn-quiet.sh install -DskipTests > For my understanding, what will this do and why does building the fe depend This will "install" the impala-parent module into your local m2 cache. Roughly, it's "cp pom.xml ~/.m2/repository/org/apache/impala/impala-parent", but in a fancy way. This is a fast operation (about a second). Sometimes, Maven, in its infinite wisdom, will see that the parent has a relative path and will read it from there. Other times, it won't. In the case of "fe", if we don't "mvn install" the impala-parent first, when you do "mvn -DskipTests install" in fe, it'll fail eventually because fe depends on impala-data-source, whose parent it can't find. It's not smart enough to realize that it's the same parent as the current pom and that it already knows the relative path. (The error is "[ERROR] Failed to execute goal on project impala-frontend: Could not resolve dependencies for project org.apache.impala:impala-frontend:jar:0.1-SNAPSHOT: Failed to collect dependencies at org.apache.impala:impala-data-source-api:jar:1.0-SNAPSHOT: Failed to read artifact descriptor for org.apache.impala:impala-data-source-api:jar:1.0-SNAPSHOT: Could not find artifact org.apache.impala:impala-parent:pom:0.1-SNAPSHOT -> [Help 1]") Day to day, you'll run "mvn install" in impala-parent once, and after that your workflow won't change. $time mvn install OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0 [INFO] Scanning for projects... [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Apache Impala Parent POM 0.1-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ impala-parent --- [INFO] Installing /home/philip/src/Impala/impala-parent/pom.xml to /home/philip/.m2/repository/org/apache/impala/impala-parent/0.1-SNAPSHOT/impala-parent-0.1-SNAPSHOT.pom [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.233 s [INFO] Finished at: 2017-12-06T08:35:10-08:00 [INFO] Final Memory: 8M/481M [INFO] ------------------------------------------------------------------------ real 0m1.102s user 0m3.156s sys 0m0.128s -- To view, visit http://gerrit.cloudera.org:8080/8753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id744e4357ee4d8e4be4e5490b2159bb76a2192f0 Gerrit-Change-Number: 8753 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2017 18:10:28 +0000 Gerrit-HasComments: Yes
