Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 )
Change subject: IMPALA-6281: Fix use-after-free in InitAuth() ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8777/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8777/1//COMMIT_MSG@9 PS1, Line 9: Previously, we implicitly create a local string object created from > nit: can you briefly mention why this was found now / when it was introduce Done http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/rpc-mgr-test.cc@57 PS1, Line 57: static string CURRENT_EXECUTABLE_PATH; > Should we make this a char* (and spell all uppercase)? Changed the interface of InitAuth() back to taking const string& in PS2. Switched to upper case. http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/rpc/thrift-server-test.cc@94 PS1, Line 94: static string CURRENT_EXECUTABLE_PATH; > Change to char*, upper case? Changed the interface of InitAuth() back to taking const string& in PS2. Switch to upper case. http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/transport/TSasl.h File be/src/transport/TSasl.h: http://gerrit.cloudera.org:8080/#/c/8777/1/be/src/transport/TSasl.h@213 PS1, Line 213: life time > nit: lifetime Done -- To view, visit http://gerrit.cloudera.org:8080/8777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f29c2396df114264dfc23726b8ba778f50e12e9 Gerrit-Change-Number: 8777 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Wed, 06 Dec 2017 22:13:05 +0000 Gerrit-HasComments: Yes
