Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 )
Change subject: IMPALA-2248: Make idle_session_timeout a query option ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/8490/10/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8490/10/be/src/service/client-request-state.cc@207 PS10, Line 207: UpdateSessionTimeout(atoi(value.c_str())); > OK, I restructured my code. Now the validation mainly happens in SetQueryOp Can we also add a couple of test cases to "set.test" to test the validation logic for out of range values, etc? I see you added coverage of the > --idle_session_timeout case already. http://gerrit.cloudera.org:8080/#/c/8490/11/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/8490/11/be/src/service/impala-hs2-server.cc@333 PS11, Line 333: } else if (iequals(v.first, "idle_session_timeout")) { > I modified the code structure, now some part of the validation is done in S This seems overall better, thanks! http://gerrit.cloudera.org:8080/#/c/8490/11/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/8490/11/fe/src/test/java/org/apache/impala/service/JdbcTest.java@626 PS11, Line 626: int sleepPeriod = (int)(timeout * timeoutTolerance * 1000) + 500; > Right, that's the idea. I implemented this test case based on test_concurre Yeah I like the test case, just took a while to understand it initially. -- To view, visit http://gerrit.cloudera.org:8080/8490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e Gerrit-Change-Number: 8490 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Dec 2017 01:08:29 +0000 Gerrit-HasComments: Yes
