Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8788 )
Change subject: IMPALA-6285: Don't print stack trace on RPC errors. ...................................................................... IMPALA-6285: Don't print stack trace on RPC errors. There is not much benefit in printing the stack trace when Thrift RPC hits an error. As long as we print enough info about the error and identify the caller, that should be sufficient. In fact, it has been observed that stack crawl caused unnecessary CPU spikes in the past. This change replaces Status() with Status::Expected() in DoRpc(), RetryRpc(), RetryRpcRecv() and Coordinator::BackendState::Exec() to avoid unnecessary stack crawls. Testing done: private core build. Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 --- M be/src/runtime/client-cache.h M be/src/runtime/coordinator-backend-state.cc 2 files changed, 30 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/8788/2 -- To view, visit http://gerrit.cloudera.org:8080/8788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Gerrit-Change-Number: 8788 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]>
