Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8788 )
Change subject: IMPALA-6285: Don't print stack trace on RPC errors. ...................................................................... IMPALA-6285: Don't print stack trace on RPC errors. There is not much benefit in printing the stack trace when Thrift RPC hits an error. As long as we print enough info about the error and identify the caller, that should be sufficient. In fact, it has been observed that stack crawl caused unnecessary CPU spikes in the past. This change replaces Status() with Status::Expected() in DoRpc(), RetryRpc(), RetryRpcRecv() and Coordinator::BackendState::Exec() to avoid unnecessary stack crawls. Testing done: private core build. Verified error strings with test_rpc_timeout.py and test_rpc_exception.py Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Reviewed-on: http://gerrit.cloudera.org:8080/8788 Reviewed-by: Michael Ho <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/runtime/client-cache.h M be/src/runtime/coordinator-backend-state.cc M common/thrift/generate_error_codes.py 3 files changed, 31 insertions(+), 16 deletions(-) Approvals: Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia83294494442ef21f7934f92ba9112e80d81fa58 Gerrit-Change-Number: 8788 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
