Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8801
Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming ...................................................................... IMPALA-5191: Behavior of column aliases should be more standard conforming We should not perform alias substitution in the subexpressions of GROUP BY. This commit allows Impala to accept "column alias" and "Column name" indistinctly in the group by clause (also if Column is made by a function). A flag called onlyTopLevel is added to the alias substitution methods. If the flag is true, the methods don't substitute the aliases of child expressions. Two extra checks are added to AnalyzeExprsTest.java. Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 --- M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/QueryStmt.java M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 7 files changed, 34 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/8801/1 -- To view, visit http://gerrit.cloudera.org:8080/8801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0f82483b486acf6953876cfa672b0d034f3709a8 Gerrit-Change-Number: 8801 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
