Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8670 )
Change subject: IMPALA-6242: Reduce flakiness in TimerCounterTest ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8670/3/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/8670/3/be/src/util/runtime-profile-test.cc@631 PS3, Line 631: DCHECK We should use EXPECT_TRUE. DCHECK crashes the process and is also removed in release builds. -- To view, visit http://gerrit.cloudera.org:8080/8670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc038908857060ccbabfe30c46e72fd93907f412 Gerrit-Change-Number: 8670 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Dec 2017 16:33:35 +0000 Gerrit-HasComments: Yes
